Re: [PATCH 1/3] bus: ti-sysc: fix I2C quirk for OMAP3 variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bus: ti-sysc: undocumented revision_doubleword member in struct
  sysc kernel-doc
--

commit 0008e125c797b0d08a6fb8ecb495aa9e3c3c8337
Author: Andreas Kemnade <andreas@kemnade.info>

bus: ti-sysc: fix I2C quirk for OMAP3 variants

This commit tracks whether the revision register spans two 16-bit words via
a revision_doubleword flag in struct sysc instead of relying on the upper
revision bits or a fake 8-byte register range on OMAP3 I2C controllers.

> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> index 12285ad9ef51f..c07a0e1f9a878 100644
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -153,6 +153,7 @@ struct sysc {
>  	struct ti_sysc_cookie cookie;
>  	const char *name;
>  	u32 revision;
> +	bool revision_doubleword;
>  	u32 sysconfig;
>  	unsigned int reserved:1;
>  	unsigned int enabled:1;

[Severity: Low]
struct sysc has a kernel-doc comment above it, so adding revision_doubleword
without a matching @revision_doubleword description triggers a W=1 kernel-doc
warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-i2c-sysc-v1-0-8945eb1d38f0@kemnade.info?part=1