From: sashiko-bot@kernel.org
To: "Cai Xinchen" <caixinchen1@huawei.com>
Cc: linux-security-module@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH -next -v2 3/8] lockdown: select SECURITYFS
Date: Tue, 10 Nov 2026 13:05:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-207076@kernel.org> (raw)
In-Reply-To: <20261110132818.2231593-4-caixinchen1@huawei.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] lockdown: missing Fixes trailer for commit 000d388ed3bb
--
commit 721e2eb133b0424c2cffa079b553baff1406aa9c
Author: Cai Xinchen <caixinchen1@huawei.com>
> lockdown: select SECURITYFS
>
> The lockdown LSM exposes /sys/kernel/security/lockdown, but it does not
> select SECURITYFS. If SECURITYFS is disabled, securityfs_create_file()
> returns -ENODEV, lockdown_secfs_init() fails and the LSM framework logs:
>
> failed LSM lockdown core initcall with errno -19
>
> while the sysfs interface advertised by the Kconfig help text is missing.
>
> Select SECURITYFS like the other LSMs that create securityfs entries
> (AppArmor, SafeSetID, TOMOYO and IMA) already do.
>
> Signed-off-by: Cai Xinchen <caixinchen1@huawei.com>
[Severity: Low]
This fixes the missing SECURITYFS dependency in SECURITY_LOCKDOWN_LSM.
Should this include:
Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110132818.2231593-1-caixinchen1@huawei.com?part=3
next prev parent reply other threads:[~2026-11-10 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 13:28 [PATCH -next -v2 0/8] lockdown: fix the securityfs interface and add tests Cai Xinchen
2026-11-10 13:28 ` [PATCH -next -v2 1/8] lockdown: Add break in lockdown_write Cai Xinchen
2026-11-10 12:59 ` sashiko-bot
2026-11-10 13:28 ` [PATCH -next -v2 2/8] lockdown: remove useless decrement operation Cai Xinchen
2026-11-10 13:02 ` sashiko-bot
2026-11-10 13:28 ` [PATCH -next -v2 3/8] lockdown: select SECURITYFS Cai Xinchen
2026-11-10 13:05 ` sashiko-bot [this message]
2026-11-10 13:28 ` [PATCH -next -v2 4/8] lsm: remove unused lockdown audit data Cai Xinchen
2026-11-10 13:08 ` sashiko-bot
2026-11-10 13:28 ` [PATCH -next -v2 5/8] lockdown: drop an unused include and move lockdown_reasons Cai Xinchen
2026-11-10 13:11 ` sashiko-bot
2026-11-10 13:28 ` [PATCH -next -v2 6/8] lockdown: bound the status string with scnprintf Cai Xinchen
2026-11-10 13:12 ` sashiko-bot
2026-11-10 13:42 ` Serge E. Hallyn
2026-11-10 13:28 ` [PATCH -next -v2 7/8] Documentation/ABI: document the lockdown securityfs file Cai Xinchen
2026-11-10 13:15 ` sashiko-bot
2026-11-10 13:28 ` [PATCH -next -v2 8/8] selftests/lsm: add lockdown securityfs test Cai Xinchen
2026-11-10 13:25 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207076@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=caixinchen1@huawei.com \
--cc=linux-security-module@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.