Re: [PATCH] pinctrl: sunxi: a733: do not switch the mux to read IRQ lines

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] pinctrl: sunxi: wrong A733 IRQ bank offset calculation in
  sunxi_irq_base_reg() [1]
--

commit e0da3dde27e4a3b5c2c95273c0b30e65e89fd5f3
Author: Vinicius Pedrosa <vinicius.eduardo.pedrosa@gmail.com>

pinctrl: sunxi: a733: do not switch the mux to read IRQ lines

This commit removes irq_read_needs_mux from a733_pinctrl_data so that reading
an interrupt line does not switch the pin mux to function 6 instead of keeping
A733's interrupt function 14.

> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c b/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
> index ca82f08a3a65b..456d9170c2a27 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
> @@ -23,7 +23,6 @@ static const u8 a733_irq_bank_muxes[SUNXI_PINCTRL_MAX_BANKS] =
>  
>  static struct sunxi_pinctrl_desc a733_pinctrl_data = {
>  	.irq_banks = 10,
> -	.irq_read_needs_mux = true,
>  	.io_bias_cfg_variant = BIAS_VOLTAGE_PIO_POW_MODE_SEL,
>  };

[Severity: High]
This problem wasn't introduced by this patch, but does sunxi_irq_base_reg()
calculate the wrong IRQ bank MMIO offset for a733_pinctrl_data [1]?

drivers/pinctrl/sunxi/pinctrl-sunxi.h:sunxi_irq_base_reg() {
	if (pctl->flags & SUNXI_PINCTRL_NCAT3_REG_LAYOUT)
		return pctl->bank_offset + bank * pctl->bank_mem_size +
		       A733_IRQ_REGS_OFFSET;

	return IRQ_REGS_OFFSET +
	       sunxi_irq_hw_bank_num(pctl->desc, bank) * IRQ_MEM_SIZE;
}

Because A733 implements no PA pins (a733_nr_bank_pins[0] == 0),
sunxi_pinctrl_dt_table_init() assigns logical IRQ banks 0..9 to ports PB..PK,
whose hardware banks are 1..10.  However, a733_pinctrl_data omits
irq_bank_map, and the SUNXI_PINCTRL_NCAT3_REG_LAYOUT branch in
sunxi_irq_base_reg() multiplies the logical bank index directly by
pctl->bank_mem_size without calling sunxi_irq_hw_bank_num().

As a result, IRQ register accesses target hardware banks 0..9 (PA..PJ)
instead of 1..10 (PB..PK), shifting every port's interrupt registers by one
bank and leaving port PK interrupts unmasked and uncleared at probe.

[1] https://sashiko.dev/#/bug/linux-213c0bba-8e71-4432-952e-9f5e320fd4b7

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110130157.112155-1-vinicius.eduardo.pedrosa@gmail.com?part=1