Re: [PATCH v11 5/7] dt-bindings: clock: nxp,imx95-blk-ctl: Add LDB bridge child node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: clock: nxp,imx95-blk-ctl: split variant schemas
  with subnodes
--

commit 40c5ccb540e5f895cb96974a17da3a21e1ed5c2d
Author: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

dt-bindings: clock: nxp,imx95-blk-ctl: Add LDB bridge child node

This commit adds a bridge child node pattern to the nxp,imx95-blk-ctl
binding schema for nxp,imx94-lvds-csr to support LVDS Display Bridge
controllers.

> diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> index fbbf1b3f17904..c2aeb434a8102 100644
> --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> @@ -51,6 +51,10 @@ patternProperties:
>      $ref: /schemas/media/fsl,imx95-csi-formatter.yaml#
>      unevaluatedProperties: false
>  
> +  '^bridge@[0-9a-f]+$':
> +    type: object
> +    $ref: /schemas/display/bridge/fsl,ldb.yaml#
> +
>  required:
>    - compatible
>    - reg
> @@ -63,7 +67,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: nxp,imx95-camera-csr
> +            enum:
> +              - nxp,imx94-lvds-csr
> +              - nxp,imx95-camera-csr
>      then:
>        required:
>          - '#address-cells'
> @@ -72,8 +78,24 @@ allOf:
>        properties:
>          '#address-cells': false
>          '#size-cells': false
> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: nxp,imx95-camera-csr
> +    then:
>        patternProperties:
>          '^formatter@[0-9a-f]+$': false
> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: nxp,imx94-lvds-csr
> +    then:
> +      patternProperties:
> +        '^bridge@[0-9a-f]+$': false
>  
>  additionalProperties: false

[Severity: Low]
This isn't a bug, but would it be cleaner to split CSR variants that have
subnodes (such as nxp,imx94-lvds-csr and nxp,imx95-camera-csr) into
separate binding schemas, similar to nxp,imx95-display-master-csr.yaml?

Adding a second variant-specific child node pattern to
nxp,imx95-blk-ctl.yaml requires three separate per-compatible if-then
blocks in allOf to toggle #address-cells, #size-cells, formatter@[0-9a-f]+,
and bridge@[0-9a-f]+ across unrelated CSR blocks.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-dcif-upstreaming-v11-0-9e13c85ae0d8@oss.nxp.com?part=5