Re: [PATCH] ASoC: es8316: Allow more time for headset mic bias to settle

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] ASoC: es8316: uninitialized variable read in es8316_irq() [1]
--

commit 83fd03ee6536ad322b774377b945917b625ffca5
Author: Ilya Muhamadeev <nicourced@altlinux.org>

ASoC: es8316: Allow more time for headset mic bias to settle

This commit increases the settling delay in
es8316_enable_micbias_for_mic_gnd_short_detect() from 20 ms to 100 ms so
that ES8316_GPIO_FLAG_GM_NOT_SHORTED settles before jack detection reads
ES8316_GPIO_FLAG.

> diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
> index 334ac9119c18f..470c503010fc1 100644
> --- a/sound/soc/codecs/es8316.c
> +++ b/sound/soc/codecs/es8316.c
> @@ -616,7 +616,7 @@ static void es8316_enable_micbias_for_mic_gnd_short_detect(
>  	snd_soc_dapm_sync_unlocked(dapm);
>  	snd_soc_dapm_mutex_unlock(dapm);
>  
> -	msleep(20);
> +	msleep(100);
>  }

[Severity: Medium]
This problem wasn't introduced by this patch, but can es8316_irq()
evaluate an uninitialized flags variable [1] if regmap_read() fails?

sound/soc/codecs/es8316.c:es8316_irq() {
	...
	unsigned int flags;

	guard(mutex)(&es8316->lock);

	regmap_read(es8316->regmap, ES8316_GPIO_FLAG, &flags);
	if (flags == 0x00)
		return IRQ_HANDLED; /* Powered-down / reset */
	...
	} else if (!(es8316->jack->status & SND_JACK_HEADPHONE)) {
		/* Jack inserted, determine type */
		es8316_enable_micbias_for_mic_gnd_short_detect(comp);
		regmap_read(es8316->regmap, ES8316_GPIO_FLAG, &flags);
		if (es8316->jd_inverted)
			flags ^= ES8316_GPIO_FLAG_HP_NOT_INSERTED;
	...
}

Neither regmap_read() call checks for errors.  If an I2C read fails (or
returns -EBUSY while the regcache is in cache-only mode during resume),
es8316_irq() branches on indeterminate stack data, which can report bogus
jack events to userspace or leave mic bias enabled in the wrong state.

[1] https://sashiko.dev/#/bug/linux-3f2856a8-3cfe-4dc1-bfa0-d15ea515aabd

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110145835.106381-1-nicourced@altlinux.org?part=1