All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>,
	"Josh Poimboeuf" <jpoimboe@kernel.org>,
	"Miroslav Benes" <mbenes@suse.cz>,
	"Petr Mladek" <pmladek@suse.com>,
	"Joe Lawrence" <joe.lawrence@redhat.com>
Cc: "Song Liu" <song@kernel.org>,
	"Marcos Paulo de Souza" <mpdesouza@suse.com>,
	"Eva Kurchatova" <eva.kurchatova@virtuozzo.com>,
	"Yafang Shao" <laoar.shao@gmail.com>,
	"Shuah Khan" <shuah@kernel.org>,
	live-patching@vger.kernel.org
Subject: Re: [PATCH v4 2/4] selftests/livepatch: clean the test modules without a kernel build directory
Date: Tue, 10 Nov 2026 16:35:12 +0000	[thread overview]
Message-ID: <sashiko-outbox-207388@kernel.org> (raw)
In-Reply-To: <20261110161050.2451750-3-sashal@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/livepatch: missing Fixes: trailer in commit message
--

commit d55e0dca037d90570993238825fe598e3b4846aa
Author: Sasha Levin <sashal@kernel.org>

> selftests/livepatch: clean the test modules without a kernel build directory
>
> "make clean" removes the test modules only when KDIR exists, and KDIR
> defaults to the build directory of the running kernel. Modules built
> for another kernel are therefore left in the source tree by a plain
> "make clean" on a machine without the running kernel's devel files,
> for example after building them as KernelCI does:
>
>   make -C tools/testing/selftests O=<kernel> KDIR=<kernel> TARGETS=livepatch
>   make -C tools/testing/selftests TARGETS=livepatch clean
>
> Removing external modules does not need a configured kernel. Clean
> them through the kernel source tree that contains the selftests, and
> do not pass on O= or KBUILD_OUTPUT, which the kernel Makefile would
> take as its build directory.
>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

[Severity: Low]
This fixes the KDIR check on the clean target.  Should it include:

  Fixes: 54ee3526796f ("selftests: livepatch: Avoid running the tests if kernel-devel is missing")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110161050.2451750-1-sashal@kernel.org?part=2

  reply	other threads:[~2026-11-10 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 16:10 [PATCH v4 0/4] selftests/livepatch: build and run the tests outside the running kernel Sasha Levin
2026-11-10 16:10 ` [PATCH v4 1/4] selftests/livepatch: skip the tests on kernels without livepatch Sasha Levin
2026-11-10 16:10 ` [PATCH v4 2/4] selftests/livepatch: clean the test modules without a kernel build directory Sasha Levin
2026-11-10 16:35   ` sashiko-bot [this message]
2026-11-10 16:10 ` [PATCH v4 3/4] selftests/livepatch: build the test modules against the kernel in O= Sasha Levin
2026-11-10 16:53   ` sashiko-bot
2026-11-10 16:10 ` [PATCH v4 4/4] selftests/livepatch: run the tests with prebuilt test modules Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-207388@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eva.kurchatova@virtuozzo.com \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=laoar.shao@gmail.com \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=mpdesouza@suse.com \
    --cc=pmladek@suse.com \
    --cc=sashal@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.