From: sashiko-bot@kernel.org
To: "Jeff Roach" <jeff.roach0@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: Add HP OmniBook X 16-cp1
Date: Tue, 10 Nov 2026 20:41:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-207724@kernel.org> (raw)
In-Reply-To: <20261110202445.14100-3-jeff.roach0@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] arm64: dts: qcom: mahua-hp-omnibook-x16 needlessly disables
supported GPU
- [Low] arm64: dts: qcom: mahua-hp-omnibook-x16 overrides CoB
usb_2_qmpphy refgen
--
commit 3e113b861ffbde20b418ef1c9fd0df962bea91d4
Author: Jeff Roach <jeff.roach0@gmail.com>
arm64: dts: qcom: Add HP OmniBook X 16-cp1
This commit adds the Device Tree for the HP OmniBook X 16-cp1 laptop based
on the Qualcomm Mahua SoC.
> diff --git a/arch/arm64/boot/dts/qcom/mahua-hp-omnibook-x16.dts b/arch/arm64/boot/dts/qcom/mahua-hp-omnibook-x16.dts
> new file mode 100644
> index 0000000000000..1d30dff7d293e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/mahua-hp-omnibook-x16.dts
[ ... ]
> +&gmu {
> + status = "disabled";
> +};
> +
> +&gpu {
> + status = "disabled";
> +};
[Severity: Medium]
Should these status = "disabled" overrides and the corresponding commit
message note be dropped so &gpu and &gmu remain enabled as inherited from
mahua.dtsi?
Adreno X2-85 support was added in commit dbd5d59091f2 ("arm64: dts: qcom:
mahua: Support GPU and GMU"), which configures the qcom,adreno-gmu-x285.0
and qcom,adreno-44060000 compatibles in mahua.dtsi and already carries a
Tested-by for this laptop.
[ ... ]
> +&usb_2_qmpphy {
> + refgen-supply = <&vreg_l1c1>;
> +
> + /delete-property/ mode-switch;
> + /delete-property/ orientation-switch;
> +
> + status = "okay";
[Severity: Low]
Should refgen-supply = <&vreg_l1c1> be dropped here so &usb_2_qmpphy
inherits refgen-supply = <&vreg_l4f1> from glymur-cob.dtsi?
Commit 6fdce1f4a17b ("arm64: dts: qcom: Consolidate Glymur CoB power grid")
moved the common Chip-on-Board PMIC regulators and PHY supplies into
glymur-cob.dtsi with refgen-supply = <&vreg_l4f1> (1.2 V) rather than
vreg_l1c1 (0.912 V). Also, the commit message still mentions checking
regulator voltages against ACPI power votes, even though the RPMH
regulator nodes are no longer defined in this board DT.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110202445.14100-1-jeff.roach0@gmail.com?part=2
prev parent reply other threads:[~2026-11-10 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 20:24 [PATCH v4 0/2] arm64: dts: qcom: Add HP OmniBook X 16-cp1 Jeff Roach
2026-11-10 20:24 ` [PATCH v4 1/2] dt-bindings: arm: " Jeff Roach
2026-11-10 20:24 ` [PATCH v4 2/2] arm64: dts: " Jeff Roach
2026-11-10 20:41 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207724@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jeff.roach0@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.