Re: [PATCH v2 2/2] PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] PCI/PM: undocumented HP ZBook 15 G4 quirk with wrong
  DMI_BOARD_NAME match
--

commit bf5c6b82503708661539d00aefb0a2e0f06652af
Author: Mario Limonciello <superm1@kernel.org>

PCI/PM: Avoid D3cold for HP Spectre x360 Convertible 15-ch0xx PCIe Ports

This commit adds DMI blacklist entries to bridge_d3_blacklist[] to prevent
PCIe ports from being put into D3cold on affected HP laptops.

> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 17ec7f065682d..6bd84b9809c8d 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3039,6 +3039,24 @@ static const struct dmi_system_id bridge_d3_blacklist[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "314D"),
>  		},
>  	},
> +	{
> +		/*
> +		 * Changing power state of root port dGPU is connected fails
> +		 * https://gitlab.freedesktop.org/drm/amd/-/work_items/3389
> +		 */
> +		.ident = "HP Spectre x360 Convertible 15-ch0xx",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "83BB"),
> +		},
> +	},
> +	{
> +		.ident = "HP ZBook 15 G4",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
> +			DMI_MATCH(DMI_BOARD_NAME, "HP ZBook 15 G4"),
> +		},
> +	},

[Severity: Medium]
Can this HP ZBook 15 G4 entry ever match a target machine when checking
DMI_BOARD_NAME against "HP ZBook 15 G4"?

On HP systems, DMI_BOARD_NAME is a 4-character hex board ID (like "83BB"
above, or "8275" on the HP ZBook 15 G4), while "HP ZBook 15 G4" is the
DMI_PRODUCT_NAME string.  Also, this entry is not mentioned in the commit
message or explained with a comment like the other entries in
bridge_d3_blacklist[]; was it included by mistake, or should it match
DMI_PRODUCT_NAME (or the hex board ID) and be documented?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-superm1-kbz-222179-v2-0-5605e6ce6454@kernel.org?part=2