Re: [PATCH v6 11/15] mm/mglru: Restrict eviction accounting to eligible zones

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] mm/mglru: undeclared identifier sc in lruvec_evictable_size()
  breaks build
--

commit bd1d7f7120c80acf045074ac097e502f51cacdb1
Author: Barry Song (Xiaomi) <baohua@kernel.org>

mm/mglru: Restrict eviction accounting to eligible zones

This commit adds a max_zone parameter to lruvec_gen_size() so that
lruvec_evictable_size() and lru_gen_imbalanced() only sum pages from
zones up to sc->reclaim_idx.

> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 8014a90e4bc29..bfc9789a999ac 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4220,7 +4220,7 @@ static void lruvec_evictable_size(struct lruvec *lruvec, int swappiness,
>  
>  	for_each_evictable_type(type, swappiness) {
>  		for (seq = min_seq[type]; seq <= max_seq; seq++)
> -			nr[type] += lruvec_gen_size(lrugen, type, seq);
> +			nr[type] += lruvec_gen_size(lrugen, type, seq, sc->reclaim_idx + 1);
>  	}
>  }

[Severity: High]
Does this break the build when CONFIG_LRU_GEN is enabled because sc is not
a parameter or local variable of lruvec_evictable_size()?

A later patch in the series, commit "mm/mglru: Avoid scan anon while
swapcache is low for GFP_NOIO allocation", adds struct scan_control *sc to
lruvec_evictable_size() and updates its callers (lruvec_is_sizable(),
lru_gen_prepare_scan() and run_eviction()), leaving this commit and the
intermediate commits unbuildable during bisection.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110202025.25736-1-baohua@kernel.org?part=11