From: sashiko-bot@kernel.org
To: "Platon Miller" <platon.ksenzenkokk@gmail.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-pci: merge duplicate 1d97:2263 entries in nvme_id_table
Date: Tue, 10 Nov 2026 23:28:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-207909@kernel.org> (raw)
In-Reply-To: <20261109202635.11310-1-platon.ksenzenkokk@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] nvme-pci: missing Fixes trailer for commit 200dccd07df2
--
commit af53f4b897c6ac918cbb3f87118e60968865a60f
Author: Platon Miller <platon.ksenzenkokk@gmail.com>
> nvme-pci: merge duplicate 1d97:2263 entries in nvme_id_table
>
> The nvme_id_table currently contains two separate entries for PCI ID
> 1d97:2263: one for SPCC with NVME_QUIRK_DISABLE_WRITE_ZEROES, and another
> later in the table for Lexar NM610 with NVME_QUIRK_BOGUS_NID.
>
> Because pci_match_device() returns on the first match, the Lexar NM610
> entry is unreachable, leaving those drives without NVME_QUIRK_BOGUS_NID.
>
> Merge the quirks for 1d97:2263 into a single entry with both
> NVME_QUIRK_DISABLE_WRITE_ZEROES and NVME_QUIRK_BOGUS_NID, and remove the
> redundant entry.
>
> Signed-off-by: Platon Miller <platon.ksenzenkokk@gmail.com>
[Severity: Low]
Since the second 1d97:2263 entry was unreachable from when it was added,
should the commit message include a Fixes tag?
Fixes: 200dccd07df2 ("nvme-pci: add NVME_QUIRK_BOGUS_NID for Lexar NM610")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109202635.11310-1-platon.ksenzenkokk@gmail.com?part=1
prev parent reply other threads:[~2026-11-10 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 20:26 [PATCH] nvme-pci: merge duplicate 1d97:2263 entries in nvme_id_table Platon Miller
2026-11-10 23:28 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207909@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=platon.ksenzenkokk@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.