From: sashiko-bot@kernel.org
To: "Serhat Kumral" <serhatkumral1@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/rdmavt: Call check_modify_qp after validating QP attributes
Date: Tue, 10 Nov 2026 23:35:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-207941@kernel.org> (raw)
In-Reply-To: <20261109201302.14531-1-serhatkumral1@gmail.com>
> rvt_modify_qp() calls the driver's check_modify_qp() hook before it
> validates the address handle attributes with rvt_check_ah().
>
> hfi1_check_modify_qp() uses the user-supplied SL in ah_to_sc() to index
> ibp->sl_to_sc[32]. The SL is a u8 that is bounds-checked only in
> hfi1_check_ah(), which runs later so an SL >= 32 causes an possible
> out-of-bounds read.
>
> Move the check_modify_qp() call after all generic attribute checks.
>
> Fixes: e85ec33d820e ("IB/rdmavt: add modify queue pair driver helpers")
> Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109201302.14531-1-serhatkumral1@gmail.com?part=1
prev parent reply other threads:[~2026-11-10 23:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 20:13 [PATCH] IB/rdmavt: Call check_modify_qp after validating QP attributes Serhat Kumral
2026-11-10 23:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207941@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=serhatkumral1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.