Re: [PATCH v2 4/9] HID: haptic, multitouch: Fix haptic device double-free and unnecessary allocation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: multitouch: Fixes trailer cites wrong commit for td->haptic
  allocation
--

commit d6cf865be3d7088ec7c4976c069b5aabfd168691
Author: Rong Zhang <i@rong.moe>

> HID: haptic, multitouch: Fix haptic device double-free and unnecessary allocation
>
> The haptic device is allocated by devm_kzalloc(), which will be freed by
> devres on HID device release. At that time, the ff core has already
> freed it on input device release previously, causing double-free.
>
> Allocate the haptic device using kzalloc_obj() to ensure its release can
> be safely delegates to the ff core.
>
> The allocation code is also moved to hid-haptic.h, so that it can be
> replaced by a stub in !CONFIG_HID_HAPTIC builds, eliminating the
> meaningless alloc-and-free sequence.
>
> Fixes: 344ff3584957 ("HID: haptic: initialize haptic device")
> Signed-off-by: Rong Zhang <i@rong.moe>

[Severity: Low]
Should the Fixes: tag reference 8d0bf7908b5a ("HID: multitouch: add
haptic multitouch support") instead, or in addition to 344ff3584957
("HID: haptic: initialize haptic device")?

344ff3584957 ("HID: haptic: initialize haptic device") only added
hid_haptic_init() in hid-haptic, whereas 8d0bf7908b5a ("HID: multitouch:
add haptic multitouch support") introduced the devm_kzalloc() allocation
of td->haptic and the hid_haptic_init() call in mt_probe().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-hid-haptic-kmod-v2-0-b835a067cb62@rong.moe?part=4