Re: [PATCH v24 06/16] ALSA: virtio: propagate playback send failures through ACK

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: virtio: missing Fixes trailer for virtsnd_pcm_pb_ack()
  error handling
--

commit 3596501a89f0fc9dc71bdef6501f19077abb9bc2
Author: Joonho Lee <mynameisjune111@gmail.com>

> ALSA: virtio: propagate playback send failures through ACK
>
> Propagate playback submission failures through ACK and commit indirect
> accounting only after transport submission succeeds. Keep the PCM state
> and buffer-access checks synchronized with playback transfer admission.
> The existing capture ACK callback and initial queue reservation behavior
> remain together until the request-owned capture conversion in patch 12.
> That conversion introduces RX reservation, validation and refill as one
> contract.
>
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

[Severity: Low]
This fixes ignored send failures in virtsnd_pcm_pb_ack() ->
virtsnd_pcm_trans_copy(), unrolled msg->length updates in
virtsnd_pcm_msg_send(), and missing xfer_xrun checks in
virtsnd_pcm_pb_pointer() and virtsnd_pcm_cp_pointer().  Should this
include:

  Fixes: fe981e67568c ("ALSA: virtio: use ack callback")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111000543.28550-1-mynameisjune111@gmail.com?part=6