Re: [PATCH] ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: Intel: incomplete removal of unused intel-sst.h tracepoint
  header
--

commit 47a1bdb679fab28a368c73c42b9adeadd92a9bea
Author: Temitope obabi <obabitemitope765@gmail.com>

> ASoC: Intel: Remove unused sst_ipc_inbox_rdata tracepoint
>
> The sst_ipc_inbox_rdata tracepoint has had no callers since commit
> 970d299b0a0a ("ASoC: Intel: Remove unused code") removed the last one.
>
> Tracepoints that are defined take up around 5K each, even if they are
> not used. Remove this unused tracepoint.
>
> Fixes: 970d299b0a0a ("ASoC: Intel: Remove unused code")
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>

> diff --git a/include/trace/events/intel-sst.h b/include/trace/events/intel-sst.h
> index 0416e91f81817..ae7c269b0824f 100644
> --- a/include/trace/events/intel-sst.h
> +++ b/include/trace/events/intel-sst.h
> @@ -69,14 +69,6 @@ DECLARE_EVENT_CLASS(sst_ipc_mailbox,
>  		(unsigned int)__entry->offset, (unsigned int)__entry->val)
>  );
>  
> -DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_rdata,
> -
> -	TP_PROTO(unsigned int offset, unsigned int val),
> -
> -	TP_ARGS(offset, val)
> -
> -);
> -
>  DEFINE_EVENT(sst_ipc_mailbox, sst_ipc_inbox_wdata,
>  
>  	TP_PROTO(unsigned int offset, unsigned int val),

[Severity: Low]
Should the entire include/trace/events/intel-sst.h header be removed
instead of just sst_ipc_inbox_rdata?

Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") deleted
sound/soc/intel/common/sst-dsp.c, which was the only file in the tree that
defined CREATE_TRACE_POINTS and included trace/events/intel-sst.h.  The
remaining nine DEFINE_EVENT definitions and three DECLARE_EVENT_CLASS
definitions in this header also have no callers.  Because no translation
unit includes trace/events/intel-sst.h, none of these tracepoints are
compiled into the kernel image or consume memory, so the commit message
claim and the Fixes: tag are also inaccurate for this cleanup.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110132013.732-1-obabitemitope765@gmail.com?part=1