All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests/landlock: Test PR_SET_SECUREBITS mediation
Date: Wed, 11 Nov 2026 02:06:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-208066@kernel.org> (raw)
In-Reply-To: <20261110202811.2409395-3-mic@digikod.net>

> The preceding commoncap fix routes the CAP_SETPCAP check for privileged
> PR_SET_SECUREBITS requests through the ordinary capable hooks.  Add a
> focused Landlock regression test for this path.
> 
> Keep CAP_SETPCAP effective to isolate Landlock mediation and run the
> audit case in a child domain.  A privileged change returns EPERM and
> emits an exact CAP_SETPCAP record, then an unprivileged-only change
> succeeds.  After the child exits, require the domain deallocation record
> to report exactly one denial; this proves that the second operation did
> not create a hidden denial without relying on an asynchronous no-record
> timeout.
> 
> The existing check-exec securebits fixture already covers commoncap's
> privileged, unprivileged, locked, and user-namespace semantics.  Without
> the preceding fix, this Landlock audit test fails.
> 
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Günther Noack <gnoack@google.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Serge Hallyn <serge@hallyn.com>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110202811.2409395-1-mic@digikod.net?part=2


      reply	other threads:[~2026-11-11  2:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 20:28 [PATCH 0/2] Fix LSM mediation of PR_SET_SECUREBITS Mickaël Salaün
2026-11-10 20:28 ` [PATCH 1/2] capabilities: Check PR_SET_SECUREBITS with ns_capable() Mickaël Salaün
2026-11-11  1:58   ` sashiko-bot
2026-11-12 13:02   ` Serge Hallyn (AMD)
2026-11-10 20:28 ` [PATCH 2/2] selftests/landlock: Test PR_SET_SECUREBITS mediation Mickaël Salaün
2026-11-11  2:06   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-208066@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.