Re: [PATCH] drm/xe/nvlp: Drop force_probe requirement

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/xe/nvlp: probe fails in uc_fw_request() without NOVALAKE_P
  GuC fw entry
--

commit c151d6764202cd346fba551210a9c14bc69923c5
Author: Gustavo Sousa <gustavo.sousa@intel.com>

drm/xe/nvlp: Drop force_probe requirement

This commit removes the force_probe requirement from nvlp_desc so the xe
driver binds automatically to NVL-P devices.

> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 8d8f00d5dcc48..ce9bae3495b8b 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -504,7 +504,6 @@ static const struct xe_device_desc nvlp_desc = {
>  	.has_sriov = true,
>  	.max_gt_per_tile = 2,
>  	MULTI_LRC_MASK,
> -	.require_force_probe = true,
>  	.va_bits = 48,
>  	.vm_max_level = 4,
>  };

[Severity: High]
Does automatic probing on NVL-P fail in uc_fw_request() with -ENOENT
because XE_GUC_FIRMWARE_DEFS has no entry for NOVALAKE_P?

XE_GUC_FIRMWARE_DEFS only lists entries up to NOVALAKE_S, and since
XE_NOVALAKE_P is ordered after XE_NOVALAKE_S in enum xe_platform,
uc_fw_auto_select() terminates at the first entry and leaves uc_fw->path
NULL.  Without a manual xe.guc_firmware_path override, uc_fw_request()
marks GuC firmware as XE_UC_FIRMWARE_NOT_SUPPORTED and fails driver probe
with -ENOENT (and on SR-IOV VFs, uc_fw_vf_override() marks GuC firmware
unsupported before checking module parameter overrides, leaving guc->ct
uninitialized).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-nvlp-drop-force_probe-requirement-v1-1-3dd6aeac38fc@intel.com?part=1