All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH 3/4] splice: remove pipe buffer stealing
Date: Wed, 11 Nov 2026 02:39:12 +0000	[thread overview]
Message-ID: <sashiko-outbox-208103@kernel.org> (raw)
In-Reply-To: <20261110145241.536019-4-kas@kernel.org>

> Nothing calls pipe_buf_try_steal() any more.  Remove ->try_steal() from
> struct pipe_buf_operations, its implementations and the exported
> generic_pipe_buf_try_steal().
> 
> PIPE_BUF_FLAG_LRU and PIPE_BUF_FLAG_GIFT were set only for stealing, and
> go too.  page_cache_pipe_buf_release() did nothing but drop the page and
> the LRU flag, so page cache and user page buffers use
> generic_pipe_buf_release().
> 
> vmsplice() still accepts SPLICE_F_GIFT, and splice() SPLICE_F_MOVE.
> Both were hints, and nothing acts on them now.
> 
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110145241.536019-1-kas@kernel.org?part=3


  reply	other threads:[~2026-11-11  2:39 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 14:52 [PATCH 0/4] splice: remove pipe buffer stealing Kiryl Shutsemau (Meta)
2026-11-10 14:52 ` [PATCH 1/4] virtio_console: copy pipe buffers in splice_write() Kiryl Shutsemau (Meta)
2026-11-10 16:24   ` Zi Yan
2026-11-10 19:19   ` Matthew Wilcox
2026-11-11 12:36     ` Christian Brauner
2026-11-11 13:42       ` Christian Brauner
2026-11-11 16:43         ` Linus Torvalds
2026-11-11 18:53           ` Christian Brauner
2026-11-11 19:26             ` Linus Torvalds
2026-11-12  8:55               ` Arnd Bergmann
2026-11-12  9:09                 ` David Hildenbrand (Arm)
2026-11-12  9:25                   ` Arnd Bergmann
2026-11-12  9:28                     ` David Hildenbrand (Arm)
2026-11-12 10:56                       ` Arnd Bergmann
2026-11-12 11:34                         ` Arnd Bergmann
2026-11-12 17:12                           ` Linus Torvalds
2026-11-11  2:30   ` sashiko-bot
2026-11-10 14:52 ` [PATCH 2/4] fuse: don't move pipe buffers into the page cache Kiryl Shutsemau (Meta)
2026-11-10 16:25   ` Zi Yan
2026-11-11  2:35   ` sashiko-bot
2026-11-11  9:02   ` Miklos Szeredi
2026-11-10 14:52 ` [PATCH 3/4] splice: remove pipe buffer stealing Kiryl Shutsemau (Meta)
2026-11-11  2:39   ` sashiko-bot [this message]
2026-11-10 14:52 ` [PATCH 4/4] splice: replace nosteal_pipe_buf_ops with default_pipe_buf_ops Kiryl Shutsemau (Meta)
2026-11-11  2:43   ` sashiko-bot
2026-11-10 15:59 ` [PATCH 0/4] splice: remove pipe buffer stealing Linus Torvalds
2026-11-11 11:06   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-208103@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=kas@kernel.org \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.