Re: [PATCH] ALSA: hda/realtek: add micmute LED quirk for Acer Predator PHN16-72

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] ALSA: hda/realtek: duplicate 0x1025:0x1731 quirk entry in
  alc269_fixup_tbl
- [Low] ALSA: hda/realtek: missing Fixes trailer for commit 34e08ad3a8da
--

commit 5bafc10ed11e5fc65c61bd076960d71905ca3545
Author: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@gmail.com>

> ALSA: hda/realtek: add micmute LED quirk for Acer Predator PHN16-72
> 
> fix micmute LED for Acer Predator PHN16-72.
> 
> Signed-off-by: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@gmail.com>

[Severity: Low]
Since this updates the incomplete quirk added in 34e08ad3a8da ("ALSA:
hda/realtek: Add quirk for Acer Predator PHN16-72"), should this include:

  Fixes: 34e08ad3a8da ("ALSA: hda/realtek: Add quirk for Acer Predator PHN16-72")

> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index a756e0076021a..fa78a36bba5ff 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7553,6 +7553,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1025, 0x170f, "Acer Predator PHN16-71", ALC2XX_FIXUP_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1025, 0x171e, "Acer Nitro ANV15-51", ALC245_FIXUP_ACER_MICMUTE_LED),
>  	SND_PCI_QUIRK(0x1025, 0x172c, "Acer Nitro ANV16-41", ALC2XX_FIXUP_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC245_FIXUP_ACER_MICMUTE_LED),
>  	SND_PCI_QUIRK(0x1025, 0x1731, "Acer Predator PHN16-72", ALC2XX_FIXUP_HEADSET_MIC),

[Severity: Low]
Should this replace the existing 0x1025:0x1731 entry in alc269_fixup_tbl
rather than adding a second entry above it?  snd_hda_pick_fixup() stops at
the first matching SSID, and ALC245_FIXUP_ACER_MICMUTE_LED already chains
ALC2XX_FIXUP_HEADSET_MIC, leaving the second 0x1025:0x1731 entry
unreachable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111021328.16153-1-faiz.faadhillah@gmail.com?part=1