From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6775) Clamp fan control times before rounding
Date: Wed, 11 Nov 2026 03:02:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-208146@kernel.org> (raw)
In-Reply-To: <20261111024607.9712-1-zhujun2@cmss.chinamobile.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] hwmon: (nct6775) missing Fixes: trailer for step_time_to_reg()
bug fix
--
commit befc95af1cfff1fb8b3fc9efb4b1e43ee7673fb9
Author: Zhu Jun <zhujun2@cmss.chinamobile.com>
> hwmon: (nct6775) Clamp fan control times before rounding
>
> store_fan_time() accepts an unsigned long, but step_time_to_reg()
> narrows it to unsigned int and adds the rounding adjustment before
> clamping. For example, 4294967295 ms wraps and selects register 1
> instead of 255 in either mode.
>
> Preserve the input width and clamp to the maximum duration for the
> selected mode before rounding.
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
[Severity: Low]
This fixes a narrowing and rounding overflow bug in step_time_to_reg().
Should this include a Fixes tag for the commit that introduced
step_time_to_reg() and store_fan_time()?
Fixes: cdcaeceb74ff ("hwmon: (nct6775) Add support for automatic fan control")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111024607.9712-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-11 3:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 2:46 [PATCH] hwmon: (nct6775) Clamp fan control times before rounding Zhu Jun
2026-11-11 3:02 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 3:39 Zhu Jun
2026-11-11 3:43 ` sashiko-bot
2026-11-11 10:57 ` David Laight
2026-11-09 10:16 Zhu Jun
2026-11-09 10:19 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208146@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.