Re: [PATCH v2 3/3] phy: exynos5-usbdrd: fix HS phy init count imbalance on Exynos2200

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] phy: exynos5-usbdrd: single-word name in Author and
  Signed-off-by
--

commit 8e448a4a6f56e4e83d90a527a88032755a420671
Author: Soheyb <soheyb_boulaa@proton.me>

> phy: exynos5-usbdrd: fix HS phy init count imbalance on Exynos2200
>
> exynos2200_usbdrd_utmi_init() calls phy_init() on the high-speed phy,
> but exynos2200_usbdrd_phy_exit() never calls phy_exit() on it. The init
> count of the high-speed phy therefore never drops back to zero: after
> the first init, every later phy_init() of it returns early, and its
> clocks and supplies stay enabled across an exit of the UTMI phy.
>
> When the high-speed phy loses power while the controller is suspended,
> it is thus not set up again on resume, and the DWC3 core soft reset
> times out:
>
>   dwc3 11210000.usb: DWC3 controller soft reset failed
>
> Exit the high-speed phy when the UTMI phy exits, last, once the rest of
> the exit has succeeded: the phy core counts a failed exit as no exit,
> so the high-speed phy has to stay initialized along with the UTMI phy.
>
> Fixes: cc52a697f87e ("phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Soheyb <soheyb_boulaa@proton.me>

[Severity: High]
Documentation/process/submitting-patches.rst requires a full real name
in the Author header and Signed-off-by tag rather than a single-word
name. Could this use your full name (for example, Soheyb Boulaa)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111032309.3365794-1-soheyb_boulaa@proton.me?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy