From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usbmon: mark concurrent accesses to the monitored flag
Date: Wed, 11 Nov 2026 03:48:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-208225@kernel.org> (raw)
In-Reply-To: <20261111034138.12642-1-zhujun2@cmss.chinamobile.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usbmon: unresolvable Fixes trailer SHA 1da177e4c3f4 in commit
message
--
commit 68910eb830ad82fcbb29334f2601dba719edc500
Author: Zhu Jun <zhujun2@cmss.chinamobile.com>
> usbmon: mark concurrent accesses to the monitored flag
>
> USB submission and completion paths read bus->monitored without taking
> mon_lock or the monitor bus lock. Adding and removing readers changes the
> flag under those locks, so the plain accesses race, as reported by KCSAN.
>
> Use READ_ONCE() for the fast-path checks and WRITE_ONCE() for the updates.
> The monitor callbacks still serialize access to their reader lists using
> the existing bus locks.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
[Severity: Low]
The commit SHA in the Fixes: trailer cannot be resolved in the repository
because the 12-character prefix 1da177e4c3f4 is ambiguous (the initial git
commit requires at least 13 characters, 1da177e4c3f41 ("Linux-2.6.12-rc2")).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111034138.12642-1-zhujun2@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-11 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 3:41 [PATCH] usbmon: mark concurrent accesses to the monitored flag Zhu Jun
2026-11-11 3:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208225@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.