From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>, linux-sound@vger.kernel.org
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v25 09/16] ALSA: virtio: bound PCM transfers and retain DMA buffers
Date: Wed, 11 Nov 2026 05:34:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-208354@kernel.org> (raw)
In-Reply-To: <20261111025655.63951-10-mynameisjune111@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: virtio: missing Fixes trailer for PCM DMA page retention
and bounds fix
--
commit 119548f8da39346df59cd856937f2c76e6900cb9
Author: Joonho Lee <mynameisjune111@gmail.com>
> ALSA: virtio: bound PCM transfers and retain DMA buffers
>
> Validate ACK geometry, conversion bounds and queued-byte accounting
> before submitting transfers. Retain the backing DMA pages until message
> retirement. Check RX status and upper payload bounds while accepting
> bounded short responses, including at STOP and PAUSE. Preserve the
> legacy RX completion and ACK policy until the request-owned conversion,
> including the legacy handling of empty PAUSE returns. The fixed-offset
> layout still has short-response data gaps; request-owned capture and its
> queue/accounting contract arrive together in patch 12. Non-MMU copies
> use only the validated returned payload length.
>
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>
[Severity: Low]
This fixes DMA page lifetime and transfer bounds handling in
virtsnd_pcm_msg_alloc() and virtsnd_pcm_msg_complete(). Should this
include:
Fixes: f40a28679e0b ("ALSA: virtio: handling control and I/O messages for the PCM device")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111025655.63951-1-mynameisjune111@gmail.com?part=9
next prev parent reply other threads:[~2026-11-11 5:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 2:56 [PATCH v25 00/16] ALSA: virtio: serialize PCM recovery and preserve capture and playback progress Joonho Lee
2026-11-11 2:56 ` [PATCH v25 01/16] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee
2026-11-11 3:02 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 02/16] ALSA: pcm: report partial progress under the stream lock Joonho Lee
2026-11-11 3:16 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 03/16] ALSA: pcm: add an optional reset operation " Joonho Lee
2026-11-11 3:38 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 04/16] ALSA: pcm: notify drivers after linked prepare completes Joonho Lee
2026-11-11 4:00 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 05/16] ALSA: pcm: serialize linked buffer actions Joonho Lee
2026-11-11 4:06 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 06/16] ALSA: virtio: propagate playback send failures through ACK Joonho Lee
2026-11-11 4:31 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 07/16] ALSA: virtio: Recover PCM state after a failed start Joonho Lee
2026-11-11 4:54 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 08/16] ALSA: virtio: Retain queued messages through device reset Joonho Lee
2026-11-11 5:10 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 09/16] ALSA: virtio: bound PCM transfers and retain DMA buffers Joonho Lee
2026-11-11 5:34 ` sashiko-bot [this message]
2026-11-11 2:56 ` [PATCH v25 10/16] ALSA: virtio: Keep control payloads alive through DMA completion Joonho Lee
2026-11-11 5:43 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 11/16] ALSA: virtio: wait through signals for PCM teardown Joonho Lee
2026-11-11 5:59 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 12/16] ALSA: virtio: use request-owned capture and serialize recovery Joonho Lee
2026-11-11 6:17 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 13/16] ALSA: virtio: prioritize capture period work Joonho Lee
2026-11-11 6:21 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 14/16] docs: describe virtio-sound capture options Joonho Lee
2026-11-11 6:26 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 15/16] ALSA: virtio: reject invalid playback completions Joonho Lee
2026-11-11 6:37 ` sashiko-bot
2026-11-11 2:56 ` [PATCH v25 16/16] ALSA: virtio: preserve playback progress across pause Joonho Lee
2026-11-11 7:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208354@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=linux-sound@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mynameisjune111@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.