Re: [PATCH] drm/xe/cri: Add new PCI IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe/cper: missing xe_device_guids entries for new CRI PCI
  IDs
--

commit 61a3e0e92a66a1e015400ed3ae42a758a161459f
Author: Ranu Maurya <ranu.maurya@intel.com>

drm/xe/cri: Add new PCI IDs

This commit adds four new Crescent Island (CRI) PCI device IDs (0x6753,
0x6754, 0x6755, and 0x6756) to INTEL_CRI_IDS.

> diff --git a/include/drm/intel/pciids.h b/include/drm/intel/pciids.h
> index ac858ed26df2e..ab02bef262f14 100644
> --- a/include/drm/intel/pciids.h
> +++ b/include/drm/intel/pciids.h
> @@ -906,7 +906,11 @@
>  	MACRO__(0x674F, ## __VA_ARGS__), \
>  	MACRO__(0x6750, ## __VA_ARGS__), \
>  	MACRO__(0x6751, ## __VA_ARGS__), \
> -	MACRO__(0x6752, ## __VA_ARGS__)
> +	MACRO__(0x6752, ## __VA_ARGS__), \
> +	MACRO__(0x6753, ## __VA_ARGS__), \
> +	MACRO__(0x6754, ## __VA_ARGS__), \
> +	MACRO__(0x6755, ## __VA_ARGS__), \
> +	MACRO__(0x6756, ## __VA_ARGS__)

[Severity: Medium]
Should xe_device_guids[] in drivers/gpu/drm/xe/xe_cper.c also be updated
with platform_id GUID entries for 0x6753, 0x6754, 0x6755, and 0x6756?

xe_device_guids[] only lists CRI device IDs 0x674C through 0x6752.  When
cper_init_record_hdr() calls lookup_device_guid() on a CRI device with one
of the new PCI IDs, the lookup fails, logs a warning ("CPER: no platform
GUID for device"), and leaves rhdr->platform_id unset in emitted CPER
records.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111055020.866766-1-ranu.maurya@intel.com?part=1