Re: [PATCH v2 8/8] arm64: dts: allwinner: orangepi-zero2: Add i2c aliases

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: allwinner: aliases for disabled and unusable I2C
  buses
--

commit ba431251208e1b9ebd8e19b71da4c12196e7c374
Author: Arun Iyengar <aiyengar1990@gmail.com>

arm64: dts: allwinner: orangepi-zero2: Add i2c aliases

This commit adds i2c0 through i2c5 aliases for the SoC TWI controllers in
the Orange Pi Zero2 board device tree.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> index d5d39bac59155..98fc83291dc83 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> @@ -12,6 +12,15 @@
>  / {
>  	model = "OrangePi Zero2";
>  	compatible = "xunlong,orangepi-zero2", "allwinner,sun50i-h616";
> +
> +	aliases {
> +		i2c0 = &i2c0;
> +		i2c1 = &i2c1;
> +		i2c2 = &i2c2;
> +		i2c3 = &i2c3;
> +		i2c4 = &i2c4;
> +		i2c5 = &r_i2c;
> +	};
>  };

[Severity: Low]
As reported by Jernej Škrabec on v1 [1], should these i2c aliases live in
overlays rather than the base board DT, especially since all six
controllers are disabled here and three of them conflict with enabled
on-board peripherals?

In particular, r_i2c (i2c5) only routes to PL0 and PL1, which this board
already uses for r_rsb to talk to the AXP305 PMIC.  Likewise, the external
pin options for i2c0 (PI5/PI6) and i2c1 (PH0/PH1 or PI7/PI8) conflict with
the enabled emac0 (ext_rgmii_pins) and uart0 (uart0_ph_pins) nodes in
sun50i-h616-orangepi-zero.dtsi.

[1] https://lore.kernel.org/r/ekjxzCRpRcWPwcDw_lDV4g@gmail.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-h616-zero2-dt-v2-0-88d8030fc975@gmail.com?part=8