From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (it87) Clamp voltage limits before multiplication
Date: Wed, 11 Nov 2026 06:54:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-208469@kernel.org> (raw)
In-Reply-To: <20261111064847.17317-1-zhujun2@cmss.chinamobile.com>
> set_in() accepts an unsigned long, but in_to_reg() converts it to long
> and multiplies it by 10 before clamping. Large positive limits can
> become negative and select register zero instead of the maximum.
>
> Keep the unsigned input type and clamp the voltage before scaling it by
> the ADC resolution.
>
> Fixes: ead8080351c9 ("hwmon: (it87) Add support for IT8732F")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111064847.17317-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-11 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 6:48 [PATCH] hwmon: (it87) Clamp voltage limits before multiplication Zhu Jun
2026-11-11 6:54 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-09 9:27 Zhu Jun
2026-11-09 20:02 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208469@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.