From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: pty: mark lockless flow control snapshots
Date: Wed, 11 Nov 2026 06:54:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-208471@kernel.org> (raw)
In-Reply-To: <20261111064744.17235-1-zhujun2@cmss.chinamobile.com>
> The PTY write and write-room callbacks inspect flow.stopped without
> flow.lock, while TCXONC updates it under that lock. KCSAN reports the
> write-room check racing with __stop_tty().
>
> These callbacks take a snapshot of flow control: the state can change
> again before a write, and the flip-buffer operations provide their own
> serialization. Use data_race(READ_ONCE()) for both checks to document the
> intentional race and ensure each check uses a single load.
>
> Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111064744.17235-1-zhujun2@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-11 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 6:47 [PATCH] tty: pty: mark lockless flow control snapshots Zhu Jun
2026-11-11 6:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208471@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.