From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (w83791d) Clamp voltage limits before rounding
Date: Wed, 11 Nov 2026 07:04:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-208487@kernel.org> (raw)
In-Reply-To: <20261111065313.17748-1-zhujun2@cmss.chinamobile.com>
> IN_TO_REG() adds the rounding adjustment before checking the register
> range. For an unsigned sysfs input such as ULONG_MAX, this addition
> wraps and selects zero instead of the maximum voltage limit.
>
> Clamp the millivolt value to the representable range before rounding to
> 16 mV register units.
>
> Fixes: 9873964d6eb2 ("[PATCH] HWMON: w83791d: New hardware monitoring driver for the Winbond W83791D")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111065313.17748-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-11 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 6:53 [PATCH] hwmon: (w83791d) Clamp voltage limits before rounding Zhu Jun
2026-11-11 7:04 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-09 10:19 Zhu Jun
2026-11-09 10:21 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208487@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.