From: sashiko-bot@kernel.org
To: "Vicki Pfau" <vi@endrift.com>, linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2 3/3] HID: nintendo-switch2-usb: Clean up urb in probe error path
Date: Wed, 11 Nov 2026 07:24:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-208508@kernel.org> (raw)
In-Reply-To: <20261111065001.3626071-3-vi@endrift.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: nintendo-switch2-usb: missing Fixes trailer for
switch2_usb_probe() fix
--
commit e3ee270bfbbf6fa6ea6a7562052781a9e5556f6b
Author: Vicki Pfau <vi@endrift.com>
> HID: nintendo-switch2-usb: Clean up urb in probe error path
>
> In switch2_usb_probe the error path if the initial urb submission fails
> forgets to unanchor the urb. This patch adds that in.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://sashiko.dev/#/patchset/20261111032125.2888320-1-vi%40endrift.com?part=1
> Signed-off-by: Vicki Pfau <vi@endrift.com>
[Severity: Low]
Since this fixes a probe error path bug, should it include a Fixes tag?
Fixes: 9417132df63e ("HID: nintendo: Add preliminary Switch 2 controller driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111065001.3626071-1-vi@endrift.com?part=3
prev parent reply other threads:[~2026-11-11 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 6:49 [PATCH v2 1/3] HID: nintendo-switch2-usb: Fix potential deadlock on teardown Vicki Pfau
2026-11-11 6:49 ` [PATCH v2 2/3] HID: nintendo-switch2-usb: Improve shutdown logic with inbound message work Vicki Pfau
2026-11-11 6:49 ` [PATCH v2 3/3] HID: nintendo-switch2-usb: Clean up urb in probe error path Vicki Pfau
2026-11-11 7:24 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208508@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vi@endrift.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.