All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Xiangwu Lai" <laixiangwu@cmss.chinamobile.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/bridge: analogix_dp: Drop dead error check for analogix_dp_init_analog_func()
Date: Wed, 11 Nov 2026 08:05:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-208563@kernel.org> (raw)
In-Reply-To: <20261111080149.1567-1-laixiangwu@cmss.chinamobile.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/bridge: analogix_dp: Signed-off-by uses handle instead of
  real name
--

commit b6a1a7f2eef3c9d11adbe1470d41eb8ca3821faa
Author: laixiangwu <laixiangwu@cmss.chinamobile.com>

> drm/bridge: analogix_dp: Drop dead error check for analogix_dp_init_analog_func()
>
> analogix_dp_init_analog_func() cannot fail: since commit 917c8d192ba6ad
> ("drm/bridge: analogix_dp: don't wait for PLL lock too early") removed
> the PLL lock polling loop, the function only performs register writes
> and always returns 0.  The error check on its return value in
> analogix_dp_set_bridge() is therefore dead code.
>
> Drop the dead check and make the function void.
>
> Signed-off-by: laixiangwu <laixiangwu@cmss.chinamobile.com>

[Severity: High]
The Author header and Signed-off-by trailer use a single-word account
handle ("laixiangwu") rather than a real human name (for example,
"Firstname Lastname"), which does not meet the Developer's Certificate of
Origin requirements in Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111080149.1567-1-laixiangwu@cmss.chinamobile.com?part=1

  reply	other threads:[~2026-11-11  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  8:01 [PATCH v2] drm/bridge: analogix_dp: Drop dead error check for analogix_dp_init_analog_func() Xiangwu Lai
2026-11-11  8:05 ` sashiko-bot [this message]
2026-11-11  9:47   ` Xiangwu Lai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-208563@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laixiangwu@cmss.chinamobile.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.