Re: [PATCH v2 5/5] arm64: dts: freescale: Add support for bytesatwork i.MX93

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: freescale: imx93-bytedevkit: unused backlight-lvds
  left enabled
--

commit c60831b496cfd3af119e905c5fcb49dc6905f857
Author: Frank Obergfell <frank.obergfell@bytesatwork.ch>

arm64: dts: freescale: Add support for bytesatwork i.MX93

This commit adds device tree files for the bytesatwork i.MX93 byteENGINE
OSM module and the byteDEVKIT board.

> diff --git a/arch/arm64/boot/dts/freescale/imx93-bytedevkit.dts b/arch/arm64/boot/dts/freescale/imx93-bytedevkit.dts
> new file mode 100644
> index 0000000000000..cb5d17c8444c3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93-bytedevkit.dts

[ ... ]

> +	lcd_bl: backlight-lvds {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_lvds_backlight>;
> +		compatible = "gpio-backlight";
> +		gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
> +		default-on;
> +	};

[Severity: Low]
Should backlight-lvds be disabled or removed while the LVDS display
pipeline and touch controller on lpi2c1 are disabled?  With default-on set
and no panel referencing &lcd_bl, gpio_backlight_probe() registers an
unused backlight device and drives GPIO2_IO26 high at boot even though
only the MIPI DSI panel is active.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111081150.950272-1-frank.obergfell@bytesatwork.ch?part=5