From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: Lock saved status flag resets during startup
Date: Wed, 11 Nov 2026 08:49:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-208635@kernel.org> (raw)
In-Reply-To: <20261111084125.80910-1-zhujun2@cmss.chinamobile.com>
> serial8250_do_startup() clears lsr_saved_flags and msr_saved_flags after
> installing the IRQ handler and starting the port timer. An interrupt or
> console write can access these flags concurrently under the port lock,
> as reported by KCSAN.
>
> Hold the port lock while clearing the interrupt registers and resetting
> the saved flags, so the reset is serialized with their other users.
>
> Fixes: ad4c2aa6354f ("Serial 8250: handle saving the clear-on-read bits from the LSR and MSR")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111084125.80910-1-zhujun2@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-11 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 8:41 [PATCH] serial: 8250: Lock saved status flag resets during startup Zhu Jun
2026-11-11 8:49 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208635@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.