Re: [PATCH 2/2] ASoC: qcom: audioreach: only disconnect the route a mixer control owns

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ASoC: qcom: audioreach: stale DAPM path in
  audioreach_put_audio_mixer()
--

commit 1fff20ab243038af732f562aca3ace62e5fdcdb9
Author: Marc Herrero <marcht@proton.me>

ASoC: qcom: audioreach: only disconnect the route a mixer control owns

This commit checks audioreach_is_vmixer_connected() before disconnecting
a virtual mixer route when 0 is written to an AudioReach mixer control.

> diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topology.c
> index 612d8f03e6e98..e92408e09bac6 100644
> --- a/sound/soc/qcom/qdsp6/topology.c
> +++ b/sound/soc/qcom/qdsp6/topology.c
> @@ -1300,7 +1300,7 @@ static int audioreach_put_audio_mixer(struct snd_kcontrol *kcontrol,
>  	if (ucontrol->value.integer.value[0]) {
>  		audioreach_connect_sub_graphs(data, scontrol, dapm_scontrol, true);
>  		snd_soc_dapm_mixer_update_power(dapm, kcontrol, 1, NULL);
> -	} else {
> +	} else if (audioreach_is_vmixer_connected(data, scontrol, dapm_scontrol)) {
>  		audioreach_connect_sub_graphs(data, scontrol, dapm_scontrol, false);
>  		snd_soc_dapm_mixer_update_power(dapm, kcontrol, 0, NULL);
>  	}

[Severity: High]
Does gating snd_soc_dapm_mixer_update_power(dapm, kcontrol, 0, NULL) on
audioreach_is_vmixer_connected() leave kcontrol's DAPM path stuck
connected when switching front ends?

All front-end kcontrols on the same virtual mixer widget share one back-end
audioreach_graph_info->src_mod_inst_id, whereas each kcontrol owns its own
struct snd_soc_dapm_path in DAPM.  If front end 1 is enabled (setting
path_1->connect = 1) and front end 2 is then enabled before front end 1 is
cleared, audioreach_connect_sub_graphs() overwrites info->src_mod_inst_id
with front end 2's module instance ID.  When 0 is subsequently written to
front end 1's kcontrol, audioreach_is_vmixer_connected() returns false and
skips snd_soc_dapm_mixer_update_power(), leaving path_1->connect set to 1
so DPCM continues to treat the back end as connected to front end 1.

Only audioreach_connect_sub_graphs(data, scontrol, dapm_scontrol, false)
should be guarded by audioreach_is_vmixer_connected(), while
snd_soc_dapm_mixer_update_power(dapm, kcontrol, 0, NULL) is still called in
the else branch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-q6apm-fixes-v1-0-1beb5702b372@proton.me?part=2