From: sashiko-bot@kernel.org
To: "Guangshuo Li" <liguangshuo@mail.sdu.edu.cn>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: starfive: Fix potential per-CPU memory leak on probe failure
Date: Wed, 11 Nov 2026 12:37:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-208988@kernel.org> (raw)
In-Reply-To: <20261111-e5624093d6-perf-starfive@mail.sdu.edu.cn>
> The per-CPU hardware events remain allocated when a later probe step
> fails, although the device-managed PMU structure is released.
>
> Allocate the events with devm_alloc_percpu() so failed probing releases
> them after the interrupt handlers have been removed.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: c2b24812f7bc ("perf: starfive: Add StarLink PMU support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-e5624093d6-perf-starfive@mail.sdu.edu.cn?part=1
prev parent reply other threads:[~2026-11-11 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 12:23 [PATCH] perf: starfive: Fix potential per-CPU memory leak on probe failure Guangshuo Li
2026-11-11 12:37 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-208988@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=liguangshuo@mail.sdu.edu.cn \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.