Re: [PATCH v2 2/2] arm64: dts: qcom: sm7225: Add Samsung Galaxy Tab S7 FE LTE

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: sm7225-samsung-gts7xllite: missing display
  clocks in simple-framebuffer
--

commit 048a3dda70bddbbbba376b3ae7c313748689b1cb
Author: Vishal Balasubramanian <vishal.bala.nps@gmail.com>

arm64: dts: qcom: sm7225: Add Samsung Galaxy Tab S7 FE LTE

This commit adds initial Device Tree support for the Samsung Galaxy Tab S7
FE LTE (SM-T735) based on the Qualcomm SM7225 SoC.

> diff --git a/arch/arm64/boot/dts/qcom/sm7225-samsung-gts7xllite.dts b/arch/arm64/boot/dts/qcom/sm7225-samsung-gts7xllite.dts
> new file mode 100644
> index 0000000000000..e472e3016cb9e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7225-samsung-gts7xllite.dts
> @@ -0,0 +1,586 @@

[ ... ]

> +	chosen {
> +		framebuffer0: framebuffer {
> +			compatible = "simple-framebuffer";
> +			memory-region = <&cont_splash_memory>;
> +			width = <1600>;
> +			height = <2560>;
> +			stride = <(1600 * 4)>;
> +			format = "a8r8g8b8";
> +		};
> +	};

[Severity: Medium]
Does framebuffer0 need a clocks property (such as <&gcc GCC_DISP_AXI_CLK>)
to keep the display clocks enabled?

Because dispcc and mdss are disabled on this board, no enabled node claims
gcc_disp_axi_clk or gcc_disp_gpll0_clk.  Unlike gcc_disp_ahb_clk and
gcc_disp_cc_xo_clk, these clocks are registered in
drivers/clk/qcom/gcc-sm6350.c without CLK_IS_CRITICAL, so
clk_disable_unused() will gate them off during boot while the display is
scanning out cont_splash_memory, killing framebuffer output or hanging the
bus.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-master-v2-0-5eb864e9f38d@gmail.com?part=2