Re: [PATCH] hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] hwmon: (dell-smm) Signed-off-by trailer uses handle instead of
  real name
--

commit 161e915af112903c97c2188511e02fe97cd0316f
Author: shadyabh <shady.abh@gmail.com>

> hwmon: (dell-smm) Add Dell Pro Precision 7 16 PW716260 to fan control whitelist
>
> On the Dell Pro Precision 7 16 PW716260 the firmware fan control
> cannot be overridden using the default SMM method, writes to pwmX
> are ignored and pwmX_enable returns -EINVAL. The firmware AC fan
> policy also requests speeds below the minimum sustainable speed of
> the fans, so one fan repeatedly stops and restarts every few
> seconds at low load.
>
> Add the machine to the fan control whitelist using the
> I8K_FAN_30A3_31A3 SMM codes. With this, writing 1 to pwm1_enable
> disables automatic fan control, the fans follow the requested
> state (0: off, 1: ~2500 RPM, 2: ~3950 RPM), and writing 2 to
> pwm1_enable restores automatic fan control.
>
> Tested on BIOS 1.5.0 with kernel 7.2.15.
>
> Signed-off-by: shadyabh <shady.abh@gmail.com>

[Severity: High]
The Author header and Signed-off-by trailer use the handle "shadyabh"
instead of a full real name.  Per the Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst, patches must be signed off
using a known real name rather than a handle or pseudonym.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111150435.75965-1-shady.abh@gmail.com?part=1