Re: [PATCH v5 07/15] drm/atomic: duplicate state of all colorops

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/atomic: missing Fixes trailer for colorop state duplication
  fix
--

commit 65883c26981f13bf34ba82b7178f631ec645b8e7
Author: Melissa Wen <mwen@igalia.com>

> drm/atomic: duplicate state of all colorops
>
> Userspace expects that colorop settings of an inactive color pipeline
> persist, so that, when the color pipeline is activated again, preserves
> the values they had when it was deactivated. Colorop setup is expected
> to persist even during a suspend/resume. To snapshot colorop settings
> correctly, duplicate state of all colorops in a given plane, regardless
> of whether color pipeline is active. Depends on skipping
> drm_atomic_colorop_check() for duplicated state done in previous commit.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> Signed-off-by: Melissa Wen <mwen@igalia.com>

[Severity: Low]
This fixes the plane_state->color_pipeline condition in
drm_atomic_helper_duplicate_state() that caused inactive colorop states
to be lost across suspend and resume.  Should the commit message
include:

  Fixes: 6bf7969a145e ("drm/drm_atomic: duplicate colorop states if plane color pipeline in use")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111160814.21326-1-mwen@igalia.com?part=7