Re: [PATCH RESEND] scsi: Consistently define pci_device_ids using named initializers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] scsi: stex: shifted model comments in stex_pci_tbl mislabel
  st_P3 PCI IDs
--

commit db5880bd5d82ae26b6fc5fffb19956c877343ba5
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

scsi: Consistently define pci_device_ids using named initializers

This commit converts struct pci_device_id arrays across SCSI drivers to use
PCI_DEVICE*() helper macros and named initializers for fields such as
.driver_data, .class, and .class_mask.

> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index d4899816f7dc8..057aa4b026740 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -1489,47 +1489,80 @@ static const struct scsi_host_template driver_template = {

[ ... ]

>  	/* st_P3, pluto */
> -	{ PCI_VENDOR_ID_PROMISE, 0x8870, PCI_VENDOR_ID_PROMISE,
> -		0x8870, 0, 0, st_P3 },
> -	/* st_P3, p3 */
> -	{ PCI_VENDOR_ID_PROMISE, 0x8870, PCI_VENDOR_ID_PROMISE,
> -		0x4300, 0, 0, st_P3 },
> -
> -	/* st_P3, SymplyStor4E */
> -	{ PCI_VENDOR_ID_PROMISE, 0x8871, PCI_VENDOR_ID_PROMISE,
> -		0x4311, 0, 0, st_P3 },
> -	/* st_P3, SymplyStor8E */
> -	{ PCI_VENDOR_ID_PROMISE, 0x8871, PCI_VENDOR_ID_PROMISE,
> -		0x4312, 0, 0, st_P3 },
> +	{
> +		/* st_P3, p3 */
> +		PCI_VDEVICE_SUB(PROMISE, 0x8870, PCI_VENDOR_ID_PROMISE, 0x8870),
> +		.driver_data = st_P3,
> +	}, {
> +		/* st_P3, SymplyStor4E */
> +		PCI_VDEVICE_SUB(PROMISE, 0x8870, PCI_VENDOR_ID_PROMISE, 0x4300),
> +		.driver_data = st_P3,
> +	}, {
> +		/* st_P3, SymplyStor8E */
> +		PCI_VDEVICE_SUB(PROMISE, 0x8871, PCI_VENDOR_ID_PROMISE, 0x4311),
> +		.driver_data = st_P3,
> +	}, {
> +		PCI_VDEVICE_SUB(PROMISE, 0x8871, PCI_VENDOR_ID_PROMISE, 0x4312),
> +		.driver_data = st_P3,
> +	},

[Severity: Low]
This isn't a bug, but placing the opening brace of the 0x8870/0x8870 entry
between the pluto and p3 comments shifts the model comments for these four
st_P3 entries by one element, mislabeling 0x8870/0x8870, 0x8870/0x4300, and
0x8871/0x4311 and leaving 0x8871/0x4312 uncommented.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111183844.1906794-2-u.kleine-koenig@baylibre.com?part=1