Re: [PATCH 4/5] arm64: dts: mediatek: mt8173-amazon-suez: Enable the volume keys

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: mediatek: undocumented mediatek,mt8173-keypad
  compatible enabled
--

commit c86b4509f24bf9c0cb8e730caec069d612fff4cf
Author: Ryan Brue <ryanbrue.dev@gmail.com>

arm64: dts: mediatek: mt8173-amazon-suez: Enable the volume keys

This commit enables the SoC keypad node on mt8173-amazon-suez and configures
its matrix layout, debounce delay, and key map for the volume keys.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts b/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts
> index 6fd7777eb4912..7dc0d818a44d6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts
> @@ -250,6 +250,17 @@ light-sensor@23 {
>  	};
>  };
>  
> +&keyboard {
> +	/* Each key is reported in all eight rows of its column */
> +	keypad,num-rows = <8>;
> +	keypad,num-columns = <9>;
> +	linux,keymap = <MATRIX_KEY(0, 0, KEY_VOLUMEUP)
> +			MATRIX_KEY(0, 1, KEY_VOLUMEDOWN)>;
> +	debounce-delay-ms = <32>;
> +	wakeup-source;
> +	status = "okay";
> +};

[Severity: Low]
Does enabling &keyboard cause make dtbs_check to fail on
mt8173-amazon-suez.dtb?

In arch/arm64/boot/dts/mediatek/mt8173.dtsi, keyboard@10010000 uses
compatible = "mediatek,mt8173-keypad", "mediatek,mt6779-keypad", but
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml does not
list mediatek,mt8173-keypad in its compatible enum.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-rbrue-suez-upstreaming-amazon-suez-dts-v1-0-77b47cdea702@gmail.com?part=4