From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/4] serial: vt8500: Handle uart_add_one_port() failure
Date: Wed, 11 Nov 2026 20:00:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-209600@kernel.org> (raw)
In-Reply-To: <20261111-vt8500-serial-cleanup-v1-3-b33594a25f87@gmail.com>
> Return the error from uart_add_one_port() instead of reporting a bound
> device for a port that never registered, which would keep its clock
> running for nothing. Let devres release the clock and the remaining
> resources on that path.
>
> Set the driver data before adding the port, so that the probe can end
> on the registration call.
>
> Fixes: 304e12665a4a ("serial: Add support for UART on VIA VT8500 and compatibles")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/bug/linux-ce64cdae-9faa-4109-b7da-29b8a8c99e76
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-vt8500-serial-cleanup-v1-0-b33594a25f87@gmail.com?part=3
next prev parent reply other threads:[~2026-11-11 20:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 19:19 [PATCH 0/4] serial: vt8500: Clean up the probe Alexey Charkov
2026-11-11 19:19 ` [PATCH 1/4] serial: vt8500: Find console ports in the serial core state Alexey Charkov
2026-11-11 19:42 ` sashiko-bot
2026-11-12 13:16 ` Alexey Charkov
2026-11-11 19:19 ` [PATCH 2/4] serial: vt8500: Use devm_clk_get_enabled() Alexey Charkov
2026-11-11 19:52 ` sashiko-bot
2026-11-11 19:19 ` [PATCH 3/4] serial: vt8500: Handle uart_add_one_port() failure Alexey Charkov
2026-11-11 20:00 ` sashiko-bot [this message]
2026-11-11 19:19 ` [PATCH 4/4] serial: vt8500: Drop the port index bitmap Alexey Charkov
2026-11-11 20:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209600@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alchark@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.