Re: [PATCH 11/12] arm64: dts: hisilicon: Remove obsolete HiKey970 PMIC GPIO property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: hisilicon: pmic@0 drops gpios without adding
  interrupts
--

commit 7f4bb8b7b2bebe372f2351a8615fe76fad7f61e6
Author: Rob Herring (Arm) <robh@kernel.org>

arm64: dts: hisilicon: Remove obsolete HiKey970 PMIC GPIO property

This commit removes the gpios property from the pmic@0 node in the HiKey970
PMIC device tree.

> diff --git a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
> index 299c4ab630e85..12f1f972ffde6 100644
> --- a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
> @@ -21,7 +21,6 @@ pmic: pmic@0 {
>  
>  			#interrupt-cells = <2>;
>  			interrupt-controller;
> -			gpios = <&gpio28 0 0>;

[Severity: Medium]
Should this replace gpios with interrupt-parent = <&gpio28>; and
interrupts = <0 0>; instead of just dropping it?

Neither hikey970-pmic.dtsi nor hi3670-hikey970.dts defines interrupt-parent
or interrupts on pmic@0, so removing gpios without adding them drops the
GPIO28 line 0 interrupt connection altogether and leaves
hi6421v600_irq_probe() failing in platform_get_irq() with -ENXIO, matching
how f81d99218257 ("staging: hi6421-spmi-pmic: rename GPIO IRQ OF node")
updated Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-hisi-v1-0-6c9f5f80716c@kernel.org?part=11