Re: [PATCH v13 12/14] s390/vfio-ap: Set up for vfio-ap device migration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] s390/vfio-ap: incomplete kernel-doc on
  vfio_ap_setup_vfio_device_migration()
--

commit 4bbee35693e7530ca98001e694624b10c95b87d4
Author: Anthony Krowiak <akrowiak@linux.ibm.com>

s390/vfio-ap: Set up for vfio-ap device migration

This commit adds vfio_ap_setup_vfio_device_migration() to populate
vdev.mig_ops and vdev.migration_flags for non-SE guests and calls it from
vfio_ap_mdev_probe() before registering the device.

> diff --git a/drivers/s390/crypto/vfio_ap_migration.c b/drivers/s390/crypto/vfio_ap_migration.c
> index 4af734aeee17e..28370b1b3833e 100644
> --- a/drivers/s390/crypto/vfio_ap_migration.c
> +++ b/drivers/s390/crypto/vfio_ap_migration.c
> @@ -1316,6 +1316,28 @@ static const struct vfio_migration_ops vfio_ap_migration_ops = {
>  	.migration_get_data_size = vfio_ap_get_data_size,
>  };
>  
> +/**
> + * vfio_ap_setup_vfio_device_migration:
> + *
> + * Plug the object containing the function pointers to the migration callbacks
> + * used to facilitate migration into the vfio device and set the flags
> + * indicating migration states STOP, STOP_COPY and RESUMING are supported.
> + *
> + * @matrix_mdev: pointer to object containing the vfio device (vdev)
> + */

[Severity: Low]
Does this kernel-doc block need a short description on the identifier line
and @matrix_mdev placed before the body description?  Without a short
description after the colon, running kernel-doc with -Wall (make W=2)
warns about a missing initial short description.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111192308.2585984-1-akrowiak@linux.ibm.com?part=12