Re: [PATCH v6 07/11] rust: pci: add typed SR-IOV PF registration data

[sashiko-bot@kernel.org]

> From: Zhi Wang <zhiw@nvidia.com>
> 
> Rust PF and VF drivers bind to separate PCI devices and may reside
> in different modules. A VF driver that calls PF operations needs
> typed access to the data exposed by the PF driver. This data must
> remain valid until VF driver removal completes.
> 
> Add VfRegistration to register a pinned object in the PF's private
> data. VF drivers can borrow it after checking the requested Rust
> type, using a higher-ranked closure or a covariant lifetime encoding.
> 
> Keep VfRegistration usable when CONFIG_PCI_IOV is disabled so PF
> drivers need no configuration guards around their registration field
> or its initialization.
> 
> Capture the core callback context in the initializer. Reject active
> VFs and an occupied registration slot before initializing the payload,
> then recheck the slot before publication in case the payload initializer
> created another registration. Publish only after all fallible work.
> 
> During registration teardown, disable SR-IOV and wait for VF remove
> callbacks to finish before clearing the pointer and dropping the object.
> 
> Co-developed-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com> # include/linux/pci.h
> Signed-off-by: Simon Song <xinmengs@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111223337.508989-1-xinmengs@nvidia.com?part=7