Re: [PATCH 5/9] arm64: dts: marvell: Fix node names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: marvell: ac5: dma-bus@0 unit-address mismatches
  ranges parent addr
--

commit d32f1cd6738013623bd9cd4b37c287a2b69edbf8
Author: Rob Herring (Arm) <robh@kernel.org>

arm64: dts: marvell: Fix node names

This commit updates node names across several Marvell device tree files to
use standard naming conventions.

> diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> index 4878773883c95..814b8a2e8ea93 100644
> --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> @@ -231,7 +231,7 @@ sdhci: mmc@805c0000 {
>  		 * Dedicated section for devices behind 32bit controllers so we
>  		 * can configure specific DMA mapping for them
>  		 */
> -		behind-32bit-controller@7f000000 {
> +		dma-bus@0 {
>  			compatible = "simple-bus";
>  			#address-cells = <0x2>;
>  			#size-cells = <0x2>;

[Severity: Low]
Should this node be named dma-bus@7f000000 instead of dma-bus@0?

This node has no reg property and defines:

  ranges = <0x0 0x0 0x0 0x7f000000 0x0 0x1000000>;

In check_simple_bus_reg(), dtc skips the 2-cell child address (0x0 0x0) and
matches the unit-address against the parent /soc bus address (0x0 0x7f000000),
so building DTBs with W=1 warns:

  Warning (simple_bus_reg): /soc/dma-bus@0: simple-bus unit address format error, expected "7f000000"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-dtbs-marvell-v1-0-938788aff3ae@kernel.org?part=5