From: sashiko-bot@kernel.org
To: "Todd Freed" <toddfreed@meta.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v5 3/8] net: don't fragment decrypted skbs
Date: Thu, 12 Nov 2026 00:31:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-209927@kernel.org> (raw)
In-Reply-To: <20261111001831.3710881-4-toddfreed@meta.com>
> on transmit, skb->decrypted means the device must encrypt the skb.
> if it can't do that, then the packet should be dropped, not transmitted
> in the clear.
>
> ip_do_fragment() and ip6_fragment() on a decrypted skb produce
> fragments which have skb->decrypted unset, and can be sent out
> unencrypted.
>
> tx of individually encrypted fragments would not work anyway, because
> encrypting needs the L4 header, which non-initial fragments do not have.
>
> ktls could encrypt in sw before fragmenting. that would not work for psp
> offload which does not have a software fallback path.
>
> tcp sizes segments to the mtu, so psp and ktls socket packets normally
> [ ... ]
> them; with it they're dropped (Ip6FragFails).
>
> Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
> Fixes: 659a2899a57d ("tcp: add datapath logic for PSP with inline key exchange")
> Signed-off-by: Todd Freed <toddfreed@meta.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111001831.3710881-1-toddfreed@meta.com?part=3
next prev parent reply other threads:[~2026-11-12 0:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 0:18 [PATCH net v5 0/8] psp, tls: don't send offloaded contents in cleartext Todd Freed
2026-11-11 0:18 ` [PATCH net v5 1/8] net/mlx5e: ring the tx doorbell when an accel offload drops a packet Todd Freed
2026-11-12 0:30 ` sashiko-bot
2026-11-11 0:18 ` [PATCH net v5 2/8] psp: don't encapsulate ipv6 packets with extension headers Todd Freed
2026-11-12 0:30 ` sashiko-bot
2026-11-11 0:18 ` [PATCH net v5 3/8] net: don't fragment decrypted skbs Todd Freed
2026-11-12 0:31 ` sashiko-bot [this message]
2026-11-11 0:18 ` [PATCH net v5 4/8] ipv4: icmp: don't quote decrypted payload in icmp errors Todd Freed
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:18 ` [PATCH net v5 5/8] ipv6: icmpv6: don't quote decrypted payload in icmpv6 errors Todd Freed
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:18 ` [PATCH net v5 6/8] selftests: drv-net: psp: test ipv6 tcp socket with extension headers Todd Freed
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:18 ` [PATCH net v5 7/8] selftests: drv-net: psp: test that ipv4 psp packets aren't fragmented Todd Freed
2026-11-12 0:31 ` sashiko-bot
2026-11-11 0:18 ` [PATCH net v5 8/8] net/mlx5e: psp: tso: replace only the length in checksum seed Todd Freed
2026-11-12 0:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209927@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=toddfreed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.