Re: [PATCH] rtc: interface: fix wakeup source leak in rtc_timer_do_work()

[sashiko-bot@kernel.org]

> rtc_update_irq(), rtc_set_time() and the -ETIME paths of
> rtc_timer_enqueue() and rtc_timer_remove() call pm_stay_awake() on the
> RTC parent device before scheduling rtc->irqwork, and
> rtc_timer_do_work() balances that with pm_relax() when it is done.
> 
> Since commit e8ba8a2bc4f6 ("rtc: check if __rtc_read_time was successful
> in rtc_timer_do_work()"), a failed time read returns early without
> calling pm_relax(). A single read error then leaves the wakeup source
> active, reads of /sys/power/wakeup_count block and suspend cannot
> proceed.
> 
> Seen on an ASUS Zenbook A16 (UX3607OA), where reads of the PMIC GLINK
> RTC time out and the pmic_glink.rtc-glink.0 wakeup source stays active
> from boot. With this change the source is released after each failed
> read.
> 
> Fixes: e8ba8a2bc4f6 ("rtc: check if __rtc_read_time was successful in rtc_timer_do_work()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jesse Casco <jesse.casco@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112002125.24566-1-jesse.casco@gmail.com?part=1