Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add Samsung S5K3L6 image sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: media: s5k3l6: board and driver constraints
  hardcoded in schema
--

commit 2a414a254e5114acefaa73e7d87e80c013d1fa39
Author: Vincent Cloutier <vincent@cloutier.co>

dt-bindings: media: i2c: Add Samsung S5K3L6 image sensor

This commit adds a Device Tree binding schema for the Samsung S5K3L6 13MP
MIPI CSI-2 image sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml
> new file mode 100644
> index 0000000000000..097593d747804
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3l6.yaml

[ ... ]

> +  reset-gpios:
> +    description: Active-low reset GPIO, also used to recover from I2C errors.
> +    maxItems: 1
> +
> +  vdda-supply:
> +    description: Analog power supply.
> +
> +  vddd-supply:
> +    description: Digital core power supply.
> +
> +  vddio-supply:
> +    description: Digital I/O power supply.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2
> +
> +          link-frequencies:
> +            items:
> +              - const: 537500000
> +              - const: 600000000
> +              - const: 625000000
> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - reset-gpios

[Severity: Medium]
Does defining link-frequencies as a 3-element items list require every
board to specify all three frequencies <537500000 600000000 625000000> in
that exact order?  A 3-entry items list implicitly sets minItems: 3 and
maxItems: 3, so any board DT that uses a single frequency, a subset of
these frequencies, or a different PLL frequency derived from another input
clock rate will fail dtbs_check.

Similarly, constraining data-lanes to two lanes blocks 4-lane designs even
though the S5K3L6 hardware has a 4-lane MIPI CSI-2 interface.  Also,
reset-gpios documents Linux driver I2C recovery behavior and is marked
required for driver standby error handling rather than hardware
requirements.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112004636.739749-1-vincent.cloutier@icloud.com?part=1