All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v27 04/17] ALSA: pcm: notify drivers after linked prepare completes
Date: Thu, 12 Nov 2026 01:52:33 +0000	[thread overview]
Message-ID: <sashiko-outbox-210105@kernel.org> (raw)
In-Reply-To: <20261112004704.49758-5-mynameisjune111@gmail.com>

> A linked prepare can finish one member before another member's driver
> prepare or reset fails. Drivers that admit transfers after their own
> prepare callback can then accept an ACK while the group action is still
> incomplete.
> 
> Add an optional prepare_complete callback. After all sleeping prepare
> and reset actions have succeeded, take the group and member PCM locks,
> publish every PREPARED state, and notify opted-in drivers before
> releasing those locks. Keep the buffer locks and access gates held
> throughout the operation. A concurrent DROP observes the group before or
> after this commit point.
> 
> On a driver error, notify only the attempted prefix, including the
> failing member. On any revoked prepare, opted-in members in the affected
> prefix or group return to SETUP. Preserve DISCONNECTED members and keep
> SUSPENDED members suspended, but set both saved suspended-state fields
> to SETUP so a later prepare can recover. Leave unreached members
> untouched after a driver error. Preflight failures have no completion
> callback. A successful driver action canceled by a terminal state
> returns -ESTRPIPE or -EBADFD, respectively. A driver error keeps its
> original return value. DISCONNECTED takes precedence when a linked group
> contains both terminal states.
> 
> Do not generate a stop-timer event while closing prepare admission.
> Ordinary legacy drivers keep their existing successful preparation and
> pointer rebasing. The new callback runs with the group and member locks
> held and must neither sleep nor acquire another PCM stream lock.
> 
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112004704.49758-1-mynameisjune111@gmail.com?part=4


  reply	other threads:[~2026-11-12  1:52 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12  0:46 [PATCH v27 00/17] ALSA: virtio: preserve PCM progress Joonho Lee
2026-11-12  0:46 ` [PATCH v27 01/17] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee
2026-11-12  0:53   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 02/17] ALSA: pcm: report partial progress under the stream lock Joonho Lee
2026-11-12  1:02   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 03/17] ALSA: pcm: add an optional reset operation " Joonho Lee
2026-11-12  1:10   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 04/17] ALSA: pcm: notify drivers after linked prepare completes Joonho Lee
2026-11-12  1:52   ` sashiko-bot [this message]
2026-11-12  0:46 ` [PATCH v27 05/17] ALSA: pcm: serialize linked buffer actions Joonho Lee
2026-11-12  1:37   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 06/17] ALSA: virtio: propagate playback send failures through ACK Joonho Lee
2026-11-12  2:05   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 07/17] ALSA: virtio: Recover PCM state after a failed start Joonho Lee
2026-11-12  2:15   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 08/17] ALSA: virtio: Retain queued messages through device reset Joonho Lee
2026-11-12  2:21   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 09/17] ALSA: virtio: bound PCM transfers and retain DMA buffers Joonho Lee
2026-11-12  2:37   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 10/17] ALSA: virtio: Keep control payloads alive through DMA completion Joonho Lee
2026-11-12  2:27   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 11/17] ALSA: virtio: wait through signals for PCM teardown Joonho Lee
2026-11-12  2:42   ` sashiko-bot
2026-11-12  0:46 ` [PATCH v27 12/17] ALSA: virtio: use request-owned capture and serialize recovery Joonho Lee
2026-11-12  3:06   ` sashiko-bot
2026-11-12  0:47 ` [PATCH v27 13/17] ALSA: virtio: prioritize capture period work Joonho Lee
2026-11-12  2:48   ` sashiko-bot
2026-11-12  0:47 ` [PATCH v27 14/17] docs: describe virtio-sound capture options Joonho Lee
2026-11-12  2:51   ` sashiko-bot
2026-11-12  0:47 ` [PATCH v27 15/17] ALSA: virtio: reject invalid playback completions Joonho Lee
2026-11-12  3:02   ` sashiko-bot
2026-11-12  0:47 ` [PATCH v27 16/17] ALSA: pcm: add an explicit application pointer to indirect playback transfer Joonho Lee
2026-11-12  3:05   ` sashiko-bot
2026-11-12  0:47 ` [PATCH v27 17/17] ALSA: virtio: preserve playback progress across pause and buffer access Joonho Lee
2026-11-12  3:25   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-210105@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=mynameisjune111@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.