Re: [PATCH v2 6/6] drm/msm: mdss: Add SM7250 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/msm: mdss: missing qcom,sm7250 UBWC config breaks
  msm_mdss_init()
--

commit d4f3819a63c8f3f76b2bc3a988c5686bff7ac892
Author: Ishu Brar <patches@brar.si>

drm/msm: mdss: Add SM7250 support

This commit adds the qcom,sm7250-mdss compatible entry to mdss_dt_match.

> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
> index 259d362475c81..8097e8f9144e4 100644
> --- a/drivers/gpu/drm/msm/msm_mdss.c
> +++ b/drivers/gpu/drm/msm/msm_mdss.c
> @@ -563,6 +563,7 @@ static const struct of_device_id mdss_dt_match[] = {
>  	{ .compatible = "qcom,sm6350-mdss", .data = &data_76k8 },
>  	{ .compatible = "qcom,sm6375-mdss", .data = &data_76k8 },
>  	{ .compatible = "qcom,sm7150-mdss", .data = &data_76k8 },
> +	{ .compatible = "qcom,sm7250-mdss", .data = &data_76k8 },
>  	{ .compatible = "qcom,sm8150-mdss", .data = &data_76k8 },
>  	{ .compatible = "qcom,sm8250-mdss", .data = &data_76k8 },
>  	{ .compatible = "qcom,sm8350-mdss", .data = &data_74k },

[Severity: High]
Does qcom_ubwc_configs in drivers/soc/qcom/ubwc_config.c also need a
qcom,sm7250 entry?

Both mdss_probe() -> msm_mdss_init() and dpu_kms_hw_init() call
qcom_ubwc_config_get_data() and abort on error.  Because qcom_ubwc_configs
has no entry for qcom,sm7250, of_machine_get_match_data() returns NULL and
qcom_ubwc_config_get_data() fails with -EINVAL, preventing MDSS and DPU from
probing on SM7250.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-dpu-sm7250-v2-0-8e925a3a8a7d@brar.si?part=6