From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: ds1307: Check the calibration register read result
Date: Thu, 12 Nov 2026 07:19:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-210587@kernel.org> (raw)
In-Reply-To: <20261112071627.154412-1-zhujun2@cmss.chinamobile.com>
> m41txx_rtc_read_offset() ignores regmap_read() failures and calculates
> the calibration offset from an uninitialized control register value.
> An I2C transfer error can therefore be reported as a successful offset
> read with an arbitrary result.
>
> Return the read error before decoding the register or updating the
> caller's offset.
>
> Fixes: 79230ff64167 ("rtc: ds1307: add offset sysfs for mt41txx chips.")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112071627.154412-1-zhujun2@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-12 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:16 [PATCH] rtc: ds1307: Check the calibration register read result Zhu Jun
2026-11-12 7:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210587@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.