From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: pca963x: Preserve SMBus errors in power management callbacks
Date: Thu, 12 Nov 2026 07:28:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-210610@kernel.org> (raw)
In-Reply-To: <20261112071732.154585-1-zhujun2@cmss.chinamobile.com>
> The suspend and resume callbacks store an SMBus read result in u8,
> discarding negative error codes, and then write the resulting value
> back to MODE1. They also ignore errors from that write. A failed read
> can therefore overwrite unrelated mode bits with an error-derived value.
>
> Keep the read result in an int, stop on a read error and return the
> write result to the PM core.
>
> Fixes: 46f02b681ba2 ("leds: pca963x: Add support for suspend and resume")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261112071732.154585-1-zhujun2@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-12 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:17 [PATCH] leds: pca963x: Preserve SMBus errors in power management callbacks Zhu Jun
2026-11-12 7:28 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-210610@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.